On Tuesday 27 November 2007, Oleg Broytmann wrote: > On Fri, Nov 09, 2007 at 09:13:30AM +0200, Dan Pascu wrote: > > IMO if we use pysqlite2 or sqlite3 we shouldn't import > > encoders/decoders from the old sqlite module, but instead use base64 > > always. > > Fixed in the revisions 3158-3161 (0.7, 0.8, 0.9 and the trunk).
Hi, Oleg I think the extra if using_sqlite2 test you added is not necessary. There is already such a test a bit below that could accommodate the 2 lines: sqlite.encode = base64.encodestring sqlite.decode = base64.decodestring In fact the original try/except you have removed was inside that if using_sqlite2: block, and it would have been enough to replace that try/except block with these 2 lines. -- Dan ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ sqlobject-discuss mailing list sqlobject-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss
