> On 2011-08-09 23:48:42, Arvind Prabhakar wrote: > > /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java, lines 67-69 > > <https://reviews.apache.org/r/1439/diff/1/?file=31810#file31810line67> > > > > Any reason why this is not refactored inplace in the base class?
Because not all subclasses support Avro (JdbCUpdateExportJob and MySQLExportJob). These can be handled in follow up JIRAs. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1439/#review1369 ----------------------------------------------------------- On 2011-08-10 22:51:19, Tom White wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1439/ > ----------------------------------------------------------- > > (Updated 2011-08-10 22:51:19) > > > Review request for Sqoop. > > > Summary > ------- > > See https://issues.apache.org/jira/browse/SQOOP-305 > > > This addresses bug SQOOP-305. > https://issues.apache.org/jira/browse/SQOOP-305 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/manager/ConnManager.java 1156386 > /src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/AvroImportMapper.java 1156386 > /src/java/com/cloudera/sqoop/mapreduce/AvroInputFormat.java PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/AvroRecordReader.java PRE-CREATION > /src/java/com/cloudera/sqoop/mapreduce/ExportJobBase.java 1156386 > /src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1156386 > /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1156386 > /src/test/com/cloudera/sqoop/TestAvroExport.java PRE-CREATION > /src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java > PRE-CREATION > /src/test/com/cloudera/sqoop/TestExport.java 1156386 > /src/test/com/cloudera/sqoop/TestExportUpdate.java 1156386 > /src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1156386 > /src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1156386 > > Diff: https://reviews.apache.org/r/1439/diff > > > Testing > ------- > > > Thanks, > > Tom > >
