[
https://issues.apache.org/jira/browse/SQOOP-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087433#comment-13087433
]
[email protected] commented on SQOOP-314:
-----------------------------------------------------
bq. On 2011-08-18 22:35:36, Arvind Prabhakar wrote:
bq. > Changes look good Bilung. One high-level suggestion is to modify
OracleManager and SQLServerManager to use the new ExportBatchOutputFormat. The
classes for OracleExportOutputFormat and SQLSErverExportOutputFormat can then
be deprecated.
Done in the new patch. Thanks.
bq. On 2011-08-18 22:35:36, Arvind Prabhakar wrote:
bq. > src/java/com/cloudera/sqoop/SqoopOptions.java, line 1026
bq. > <https://reviews.apache.org/r/1585/diff/1/?file=33455#file33455line1026>
bq. >
bq. > This will trigger a checkstyle warning. Should change the argument
name to mode or something else.
Done in the new patch. Thanks.
bq. On 2011-08-18 22:35:36, Arvind Prabhakar wrote:
bq. > src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java, line
41
bq. > <https://reviews.apache.org/r/1585/diff/1/?file=33457#file33457line41>
bq. >
bq. > Longer than 80.
Done in the new patch. Thanks.
bq. On 2011-08-18 22:35:36, Arvind Prabhakar wrote:
bq. > src/java/com/cloudera/sqoop/mapreduce/AsyncSqlRecordWriter.java, line 179
bq. > <https://reviews.apache.org/r/1585/diff/1/?file=33456#file33456line179>
bq. >
bq. > Thread.stop() is unsafe operation that can lead to corruption. Would
it help if the join call was part of the try block instead of in finally? In
that case, throwing the IOException would automatically get rid of the thread.
Done in the new patch. Thanks.
- Bilung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1585/#review1531
-----------------------------------------------------------
On 2011-08-19 00:49:12, Bilung Lee wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1585/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-19 00:49:12)
bq.
bq.
bq. Review request for Sqoop, Arvind Prabhakar and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Basic export job will hang when the target database does not support
insert syntax with multiple rows of values, such as INSERT INTO tbl (col1,
col2) VALUES(11, 12),(21, 22),(23, 24)
bq.
bq. This is because, in close(), AsyncSqlRecordWriter will still wait for
AsyncSqlExecThread to finish even when an SQLException is thrown underneath.
bq.
bq. The fix is to introduce a new "--batch" option to execute underlying
statements in batch mode instead of a single multirow insert statement.
bq.
bq.
bq. This addresses bug SQOOP-314.
bq. https://issues.apache.org/jira/browse/SQOOP-314
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java d2a6cf6
bq. src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 8f629f1
bq. src/java/com/cloudera/sqoop/tool/ExportTool.java b4b1091
bq. src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 8687b0c
bq. src/docs/man/sqoop-export.txt 6090ea1
bq. src/docs/user/export.txt 4f87886
bq. src/java/com/cloudera/sqoop/SqoopOptions.java d760d39
bq. src/java/com/cloudera/sqoop/manager/OracleManager.java 6a55312
bq. src/java/com/cloudera/sqoop/manager/SQLServerManager.java e1ce2af
bq. src/java/com/cloudera/sqoop/mapreduce/AsyncSqlRecordWriter.java 193cf41
bq. src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java
PRE-CREATION
bq. src/java/com/cloudera/sqoop/mapreduce/ExportJobBase.java 9799e37
bq.
bq. Diff: https://reviews.apache.org/r/1585/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Bilung
bq.
bq.
> Basic export hangs when target database does not support INSERT syntax with
> multiple rows of values
> ---------------------------------------------------------------------------------------------------
>
> Key: SQOOP-314
> URL: https://issues.apache.org/jira/browse/SQOOP-314
> Project: Sqoop
> Issue Type: Bug
> Reporter: Bilung Lee
> Assignee: Bilung Lee
>
> Basic export job will hang when the target database does not support INSERT
> syntax with multiple rows of values, such as INSERT INTO tbl (col1, col2)
> VALUES(11, 12),(21, 22),(23, 24)
> This is because, in close(), AsyncSqlRecordWriter will still wait for
> AsyncSqlExecThread to finish even when an SQLException is thrown underneath.
> The configuration variable "sqoop.export.records.per.statement" can be set to
> 1 as a workaround for this problem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
