-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1986/
-----------------------------------------------------------
Review request for Sqoop.
Summary
-------
We make extensions for *JobContext and ConnManager and replace the uses of them
with that interface.
We then copy org.apache.sqoop.lib and org.apache.sqoop.manager to be under the
com.cloudera package to keep backwards compatability(and delete the
com.cloudera.sqoop interfaces that we just created)
This addresses bug SQOOP-344.
https://issues.apache.org/jira/browse/SQOOP-344
Diffs
-----
src/java/com/cloudera/sqoop/lib/BigDecimalSerializer.java a772608
src/java/com/cloudera/sqoop/lib/BlobRef.java 76b7947
src/java/com/cloudera/sqoop/lib/BooleanParser.java bb34e1f
src/java/com/cloudera/sqoop/lib/ClobRef.java 1fd2014
src/java/com/cloudera/sqoop/lib/DelimiterSet.java 25dbcfd
src/java/com/cloudera/sqoop/lib/FieldFormatter.java d19c142
src/java/com/cloudera/sqoop/lib/FieldMapProcessor.java 182c90b
src/java/com/cloudera/sqoop/lib/FieldMappable.java 762e402
src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 0f75868
src/java/com/cloudera/sqoop/lib/LargeObjectLoader.java a189f0b
src/java/com/cloudera/sqoop/lib/LobRef.java 5509555
src/java/com/cloudera/sqoop/lib/LobSerializer.java 906db7f
src/java/com/cloudera/sqoop/lib/ProcessingException.java 72ee7ba
src/java/com/cloudera/sqoop/lib/RecordParser.java f906589
src/java/com/cloudera/sqoop/lib/SqoopRecord.java eacebeb
src/java/com/cloudera/sqoop/manager/CatalogQueryManager.java 9ac4841
src/java/com/cloudera/sqoop/manager/ConnManager.java 2fb1947
src/java/com/cloudera/sqoop/manager/DefaultManagerFactory.java d6caff1
src/java/com/cloudera/sqoop/manager/DirectMySQLManager.java 88bb77b
src/java/com/cloudera/sqoop/manager/DirectPostgresqlManager.java abcb2a9
src/java/com/cloudera/sqoop/manager/ExportJobContext.java ac8bf7f
src/java/com/cloudera/sqoop/manager/GenericJdbcManager.java de415ce
src/java/com/cloudera/sqoop/manager/HsqldbManager.java 167bd04
src/java/com/cloudera/sqoop/manager/ImportJobContext.java f0f8525
src/java/com/cloudera/sqoop/manager/InformationSchemaManager.java 2af073e
src/java/com/cloudera/sqoop/manager/ManagerFactory.java 48f5f21
src/java/com/cloudera/sqoop/manager/MySQLManager.java cdb40a8
src/java/com/cloudera/sqoop/manager/MySQLUtils.java 8e7303c
src/java/com/cloudera/sqoop/manager/OracleManager.java 343329d
src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908
src/java/com/cloudera/sqoop/manager/SQLServerManager.java d0bd6c8
src/java/com/cloudera/sqoop/manager/SqlManager.java a08d774
src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION
src/java/org/apache/sqoop/hive/HiveImport.java PRE-CREATION
src/java/org/apache/sqoop/hive/TableDefWriter.java PRE-CREATION
src/java/org/apache/sqoop/manager/CatalogQueryManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/ConnManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/ConnManagerInterface.java PRE-CREATION
src/java/org/apache/sqoop/manager/DefaultManagerFactory.java PRE-CREATION
src/java/org/apache/sqoop/manager/DirectMySQLManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/ExportJobContext.java PRE-CREATION
src/java/org/apache/sqoop/manager/GenericJdbcManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/HsqldbManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/ImportJobContext.java PRE-CREATION
src/java/org/apache/sqoop/manager/ManagerFactory.java PRE-CREATION
src/java/org/apache/sqoop/manager/MySQLManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/OracleManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/PostgresqlManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/SQLServerManager.java PRE-CREATION
src/java/org/apache/sqoop/manager/SqlManager.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/ExportJobBase.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/ImportJobBase.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/JdbcUpsertExportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/JobBase.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java PRE-CREATION
src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION
src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION
src/java/org/apache/sqoop/util/Jars.java PRE-CREATION
src/perftest/ExtConnFactoryTest.java 305be46
src/perftest/ExtFactory.java 5432414
src/test/org/apache/sqoop/TestAppendUtils.java PRE-CREATION
src/test/org/apache/sqoop/TestConnFactory.java PRE-CREATION
src/test/org/apache/sqoop/TestIncrementalImport.java PRE-CREATION
src/test/org/apache/sqoop/TestMerge.java PRE-CREATION
src/test/org/apache/sqoop/manager/DirectMySQLTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/OracleManagerTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/OracleUtils.java PRE-CREATION
src/test/org/apache/sqoop/manager/PostgresqlTest.java PRE-CREATION
src/test/org/apache/sqoop/manager/TestHsqldbManager.java PRE-CREATION
src/test/org/apache/sqoop/manager/TestSqlManager.java PRE-CREATION
src/test/org/apache/sqoop/orm/TestClassWriter.java PRE-CREATION
src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java PRE-CREATION
src/test/org/apache/sqoop/testutil/HsqldbTestServer.java PRE-CREATION
src/test/org/apache/sqoop/testutil/InjectableConnManager.java PRE-CREATION
src/test/org/apache/sqoop/testutil/InjectableManagerFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/1986/diff
Testing
-------
mvn build and ant package I also ran ./bin/sqoop
Thanks,
Alex
