[
https://issues.apache.org/jira/browse/SQOOP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109667#comment-13109667
]
[email protected] commented on SQOOP-339:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1938/
-----------------------------------------------------------
(Updated 2011-09-21 17:13:30.493594)
Review request for Sqoop.
Changes
-------
Incorporated the latest feedback. This patch uses mknod, and then falls back to
mkfifo if the fifo wasn't actually created. The output from both commands is
logged.
Summary
-------
Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility
with Mac OS X.
This addresses bug SQOOP-339.
https://issues.apache.org/jira/browse/SQOOP-339
Diffs (updated)
-----
src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb
Diff: https://reviews.apache.org/r/1938/diff
Testing
-------
No new tests as the functionality is covered by an existing unit test. I ran
the existing unit test and it worked. I don't have a Mac to test on right now,
so it might be good to run the unit tests on one before commit.
Thanks,
Joey
> Use of non-portable mknod utility causes build problems on Mac OS X
> -------------------------------------------------------------------
>
> Key: SQOOP-339
> URL: https://issues.apache.org/jira/browse/SQOOP-339
> Project: Sqoop
> Issue Type: Bug
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Joseph Boyd
> Assignee: Joey Echeverria
> Priority: Minor
> Attachments: SQOOP-339-1.patch, SQOOP-339-2.patch, SQOOP-339-3.patch
>
>
> Duplicating this issue from SQOOP-175, which is in the cloudera JIRA
> From SQOOP-175's description by Ken Krugler :
> On Mac OS X 10.6.3, the TestNamedFifo.testNamedFifo() test fails. The error
> is caused by the Shell.execCommand() use of mknod, since (at least on my Mac)
> mknod doesn't know about the --mode=xxx parameter or the -p parameters.
> Based on
> http://stackoverflow.com/questions/4546356/is-mknod-portable-if-not-what-is-the-alternative,
> I switched the code to use mkfifo and it now passes all tests.
> The change to NamedFifo.create() is trivial:
> Shell.execCommand("mkfifo", "-m", "0" + modeStr, filename);
> But I have no way of trying this out on other OSes, so it might create a
> different compatibility issue.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
