[
https://issues.apache.org/jira/browse/SQOOP-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134541#comment-13134541
]
[email protected] commented on SQOOP-371:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2519/
-----------------------------------------------------------
(Updated 2011-10-24 21:51:42.925324)
Review request for Sqoop and Arvind Prabhakar.
Changes
-------
1. Update license header checkstyle to exclude copyright.
2. Keep static methods in util classes.
Summary
-------
1. Create the new package under org.apache.sqoop namespace.
2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes.
4. Deprecate classes under com.cloudera.sqoop namespace.
This addresses bug SQOOP-371.
https://issues.apache.org/jira/browse/SQOOP-371
Diffs (updated)
-----
./src/java/com/cloudera/sqoop/util/AppendUtils.java 1187591
./src/java/com/cloudera/sqoop/util/AsyncSink.java 1187591
./src/java/com/cloudera/sqoop/util/ClassLoaderStack.java 1187591
./src/java/com/cloudera/sqoop/util/DirectImportUtils.java 1187591
./src/java/com/cloudera/sqoop/util/ErrorableAsyncSink.java 1187591
./src/java/com/cloudera/sqoop/util/ErrorableThread.java 1187591
./src/java/com/cloudera/sqoop/util/Executor.java 1187591
./src/java/com/cloudera/sqoop/util/ExitSecurityException.java 1187591
./src/java/com/cloudera/sqoop/util/ExportException.java 1187591
./src/java/com/cloudera/sqoop/util/FileListing.java 1187591
./src/java/com/cloudera/sqoop/util/ImportException.java 1187591
./src/java/com/cloudera/sqoop/util/Jars.java 1187591
./src/java/com/cloudera/sqoop/util/JdbcUrl.java 1187591
./src/java/com/cloudera/sqoop/util/LoggingAsyncSink.java 1187591
./src/java/com/cloudera/sqoop/util/LoggingUtils.java 1187591
./src/java/com/cloudera/sqoop/util/NullAsyncSink.java 1187591
./src/java/com/cloudera/sqoop/util/OptionsFileUtil.java 1187591
./src/java/com/cloudera/sqoop/util/PerfCounters.java 1187591
./src/java/com/cloudera/sqoop/util/RandomHash.java 1187591
./src/java/com/cloudera/sqoop/util/ResultSetPrinter.java 1187591
./src/java/com/cloudera/sqoop/util/StoredAsProperty.java 1187591
./src/java/com/cloudera/sqoop/util/SubprocessSecurityManager.java 1187591
./src/java/com/cloudera/sqoop/util/TaskId.java 1187591
./src/java/org/apache/sqoop/util/AppendUtils.java PRE-CREATION
./src/java/org/apache/sqoop/util/AsyncSink.java PRE-CREATION
./src/java/org/apache/sqoop/util/ClassLoaderStack.java PRE-CREATION
./src/java/org/apache/sqoop/util/DirectImportUtils.java PRE-CREATION
./src/java/org/apache/sqoop/util/ErrorableAsyncSink.java PRE-CREATION
./src/java/org/apache/sqoop/util/ErrorableThread.java PRE-CREATION
./src/java/org/apache/sqoop/util/Executor.java PRE-CREATION
./src/java/org/apache/sqoop/util/ExitSecurityException.java PRE-CREATION
./src/java/org/apache/sqoop/util/ExportException.java PRE-CREATION
./src/java/org/apache/sqoop/util/FileListing.java PRE-CREATION
./src/java/org/apache/sqoop/util/ImportException.java PRE-CREATION
./src/java/org/apache/sqoop/util/Jars.java PRE-CREATION
./src/java/org/apache/sqoop/util/JdbcUrl.java PRE-CREATION
./src/java/org/apache/sqoop/util/LoggingAsyncSink.java PRE-CREATION
./src/java/org/apache/sqoop/util/LoggingUtils.java PRE-CREATION
./src/java/org/apache/sqoop/util/NullAsyncSink.java PRE-CREATION
./src/java/org/apache/sqoop/util/OptionsFileUtil.java PRE-CREATION
./src/java/org/apache/sqoop/util/PerfCounters.java PRE-CREATION
./src/java/org/apache/sqoop/util/RandomHash.java PRE-CREATION
./src/java/org/apache/sqoop/util/ResultSetPrinter.java PRE-CREATION
./src/java/org/apache/sqoop/util/StoredAsProperty.java PRE-CREATION
./src/java/org/apache/sqoop/util/SubprocessSecurityManager.java PRE-CREATION
./src/java/org/apache/sqoop/util/TaskId.java PRE-CREATION
./src/test/checkstyle-java-header.txt 1187139
Diff: https://reviews.apache.org/r/2519/diff
Testing
-------
Thanks,
Bilung
> Migrate util package to new name space
> --------------------------------------
>
> Key: SQOOP-371
> URL: https://issues.apache.org/jira/browse/SQOOP-371
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Bilung Lee
> Assignee: Bilung Lee
>
> 1. Create the new package under org.apache.sqoop namespace.
> 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes.
> 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop
> classes.
> 4. Deprecate classes under com.cloudera.sqoop namespace.
> Also remove copyright notice in the header.
> (http://www.apache.org/legal/src-headers.html)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
