[ https://issues.apache.org/jira/browse/SQOOP-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138601#comment-13138601 ]
jirapos...@reviews.apache.org commented on SQOOP-376: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2562/#review2912 ----------------------------------------------------------- Ship it! +1 - Arvind On 2011-10-28 17:54:47, Bilung Lee wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2562/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-10-28 17:54:47) bq. bq. bq. Review request for Sqoop and Arvind Prabhakar. bq. bq. bq. Summary bq. ------- bq. bq. 1. Create the new package under org.apache.sqoop namespace. bq. 2. Move logics from com.cloudera.sqoop classes to org.apache.sqoop classes. bq. 3. Let com.cloudera.sqoop classes inherit logics from org.apache.sqoop classes. bq. 4. Deprecate classes under com.cloudera.sqoop namespace. bq. bq. bq. This addresses bug SQOOP-376. bq. https://issues.apache.org/jira/browse/SQOOP-376 bq. bq. bq. Diffs bq. ----- bq. bq. ./src/java/com/cloudera/sqoop/mapreduce/AsyncSqlOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AsyncSqlRecordWriter.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AutoProgressMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroImportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroInputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/AvroRecordReader.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/CombineShimRecordReader.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/ExportInputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/ExportJobBase.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/HBaseImportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/HBaseImportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/ImportJobBase.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/JdbcExportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/JdbcUpdateExportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/JdbcUpsertExportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/JobBase.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeMapperBase.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeRecord.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeRecordMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeReducer.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MergeTextMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLDumpImportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLDumpInputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLDumpMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLExportJob.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLRecordExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/MySQLTextExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/NullOutputCommitter.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/OracleExportOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/OracleUpsertOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/RawKeyTextOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/SQLServerExportOutputFormat.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/SequenceFileExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/SequenceFileImportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/TextExportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/TextImportMapper.java 1190044 bq. ./src/java/com/cloudera/sqoop/mapreduce/UpdateOutputFormat.java 1190044 bq. ./src/java/org/apache/sqoop/mapreduce/AsyncSqlOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AsyncSqlRecordWriter.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AutoProgressMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroInputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/AvroRecordReader.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/CombineShimRecordReader.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/DelegatingOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/ExportInputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/ExportJobBase.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/ExportOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/HBaseImportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/HBaseImportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/ImportJobBase.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/JdbcUpsertExportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/JobBase.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeMapperBase.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeRecord.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeRecordMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeReducer.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MergeTextMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLRecordExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/MySQLTextExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/NullOutputCommitter.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/SequenceFileExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/SequenceFileImportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/TextExportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/TextImportMapper.java PRE-CREATION bq. ./src/java/org/apache/sqoop/mapreduce/UpdateOutputFormat.java PRE-CREATION bq. bq. Diff: https://reviews.apache.org/r/2562/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Bilung bq. bq. > Migrate mapreduce package to new name space > ------------------------------------------- > > Key: SQOOP-376 > URL: https://issues.apache.org/jira/browse/SQOOP-376 > Project: Sqoop > Issue Type: Sub-task > Reporter: Bilung Lee > Assignee: Bilung Lee > > Refer to SQOOP-371 for details. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira