----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2612/#review2950 -----------------------------------------------------------
Thanks for your contribution, Jarcec! Some comments below. /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java <https://reviews.apache.org/r/2612/#comment6594> Remove trailing space. /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java <https://reviews.apache.org/r/2612/#comment6605> Remove the non-static method in subclass. /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java <https://reviews.apache.org/r/2612/#comment6596> Remove trailing space. /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java <https://reviews.apache.org/r/2612/#comment6604> Should inherit from "org.apache.sqoop.metastore.hsqldb.AutoHsqldbStorage". /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java <https://reviews.apache.org/r/2612/#comment6603> Remove this constant, which is private and is not needed. /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java <https://reviews.apache.org/r/2612/#comment6606> Change to "com.cloudera.sqoop.metastore.JobStorage". I.e. should inherit from this for backward compatibility. - Bilung On 2011-10-29 14:04:59, Jarek Jarcec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2612/ > ----------------------------------------------------------- > > (Updated 2011-10-29 14:04:59) > > > Review request for Sqoop and Bilung Lee. > > > Summary > ------- > > I've migrated the metastore packages. > > > This addresses bug SQOOP-375. > https://issues.apache.org/jira/browse/SQOOP-375 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/metastore/JobData.java 1190770 > /src/java/com/cloudera/sqoop/metastore/JobStorage.java 1190770 > /src/java/com/cloudera/sqoop/metastore/JobStorageFactory.java 1190770 > /src/java/com/cloudera/sqoop/metastore/hsqldb/AutoHsqldbStorage.java > 1190770 > /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbJobStorage.java 1190770 > /src/java/com/cloudera/sqoop/metastore/hsqldb/HsqldbMetaStore.java 1190770 > /src/java/org/apache/sqoop/metastore/JobData.java PRE-CREATION > /src/java/org/apache/sqoop/metastore/JobStorage.java PRE-CREATION > /src/java/org/apache/sqoop/metastore/JobStorageFactory.java PRE-CREATION > /src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java > PRE-CREATION > /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbJobStorage.java > PRE-CREATION > /src/java/org/apache/sqoop/metastore/hsqldb/HsqldbMetaStore.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2612/diff > > > Testing > ------- > > > Thanks, > > Jarek > >
