----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2883/#review3442 -----------------------------------------------------------
Ship it! Overall the changes look good, with one comment below. Please attach the patch to the JIRA when done. /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java <https://reviews.apache.org/r/2883/#comment7685> This should be INTEGER instead. - Arvind On 2011-11-19 20:08:03, Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2883/ > ----------------------------------------------------------- > > (Updated 2011-11-19 20:08:03) > > > Review request for Sqoop and Arvind Prabhakar. > > > Summary > ------- > > I've finished user mapping by allowing redefine output for avro as well. > > > This addresses bug SQOOP-362. > https://issues.apache.org/jira/browse/SQOOP-362 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/SqoopOptions.java 1203816 > /src/java/org/apache/sqoop/SqoopOptions.java 1203816 > /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 1203816 > /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1203816 > /src/java/org/apache/sqoop/tool/ImportTool.java 1203816 > /src/test/com/cloudera/sqoop/TestAvroImport.java 1203816 > > Diff: https://reviews.apache.org/r/2883/diff > > > Testing > ------- > > * Added new test for mapping override > * Passed standard tests > * Passed check style > > > Thanks, > > Jarek > >
