[ 
https://issues.apache.org/jira/browse/SQOOP-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161409#comment-13161409
 ] 

[email protected] commented on SQOOP-397:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2983/#review3600
-----------------------------------------------------------



./COMPILING.txt
<https://reviews.apache.org/r/2983/#comment8025>

    I think 0.20.x should continue to be the default until 0.23.x has 
stabilized.



./build.xml
<https://reviews.apache.org/r/2983/#comment8026>

    Rather than using conditional logic in the build, it would be simpler to 
use the approach that Pig takes and drive the choice by a property. 
    
    Search for "hadoopversion" in 
http://svn.apache.org/repos/asf/pig/trunk/build.xml and 
http://svn.apache.org/repos/asf/pig/trunk/ivy.xml (note the way the 
configuration name is parameterized in the latter).



./ivy/libraries.properties
<https://reviews.apache.org/r/2983/#comment8027>

    We should parameterize HBase at the same time so we can switch to 0.92.0 
when it comes out, since it supports Hadoop 0.23.



./ivy/libraries.properties
<https://reviews.apache.org/r/2983/#comment8028>

    ZooKeeper too?



./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java
<https://reviews.apache.org/r/2983/#comment8029>

    Rather than commenting out, why not just add an @Ignore annotation? Also 
open a JIRA and link to it so it doesn't get forgotten.


- Tom


On 2011-12-01 18:59:33, Bilung Lee wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2983/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-01 18:59:33)
bq.  
bq.  
bq.  Review request for Sqoop, Arvind Prabhakar and Tom White.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Make Sqoop work with Hadoop 0.23
bq.  
bq.  
bq.  This addresses bug SQOOP-397.
bq.      https://issues.apache.org/jira/browse/SQOOP-397
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./COMPILING.txt 1197706 
bq.    ./build.xml 1208854 
bq.    ./ivy.xml 1208716 
bq.    ./ivy/libraries.properties 1208716 
bq.    ./src/ivy/ivy-hdp20.xml PRE-CREATION 
bq.    ./src/ivy/ivy-hdp23.xml PRE-CREATION 
bq.    ./src/ivy/libraries-hdp20.properties PRE-CREATION 
bq.    ./src/ivy/libraries-hdp23.properties PRE-CREATION 
bq.    ./src/test/com/cloudera/sqoop/TestCompression.java 1208716 
bq.    ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1208054 
bq.    ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1208054 
bq.    ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1208054 
bq.    
./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 
1208054 
bq.  
bq.  Diff: https://reviews.apache.org/r/2983/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Bilung
bq.  
bq.


                
> Make Sqoop work with Hadoop 0.23
> --------------------------------
>
>                 Key: SQOOP-397
>                 URL: https://issues.apache.org/jira/browse/SQOOP-397
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 1.4.1-incubating
>
>         Attachments: SQOOP-397.patch
>
>
> SQOOP-354 made changes to get Sqoop to compile against 0.23; this issue is to 
> get Sqoop running against 0.23, including passing tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to