----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3272/#review4028 -----------------------------------------------------------
Ship it! +1 Thanks for the patch Jarcec. The changes look good. I tested basic import against MySQL and Hadoop 0.20.205 and that seems to work. Please attach the patch to the JIRA and also update the "Bugs" field to SQOOP-413 as that is the relevant JIRA for this issue. - Arvind On 2011-12-20 17:09:54, Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3272/ > ----------------------------------------------------------- > > (Updated 2011-12-20 17:09:54) > > > Review request for Sqoop and Arvind Prabhakar. > > > Summary > ------- > > I've copypasted all four files from CHD3 release and put them into sqoop > mapreduce module (I altered files to conform our checkstyle policy). I've > also changed all references in sqoop to use this new for classes instead of > the default ones present in hadoop-0.21. > > > This addresses bug SQOOP-412. > https://issues.apache.org/jira/browse/SQOOP-412 > > > Diffs > ----- > > /src/java/com/cloudera/sqoop/mapreduce/CombineShimRecordReader.java 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/DBInputFormat.java 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java > 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java > 1221303 > /src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1221303 > > /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java > 1221303 > > /src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java > 1221303 > /src/java/org/apache/sqoop/config/ConfigurationHelper.java 1221303 > /src/java/org/apache/sqoop/lib/SqoopRecord.java 1221303 > /src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/CombineFileRecordReader.java > PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/CombineFileSplit.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/CombineShimRecordReader.java 1221303 > /src/java/org/apache/sqoop/mapreduce/DBWritable.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1221303 > /src/java/org/apache/sqoop/mapreduce/ExportInputFormat.java 1221303 > /src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1221303 > /src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java > 1221303 > /src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java > 1221303 > /src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 1221303 > /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java > 1221303 > /src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java > 1221303 > /src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java > 1221303 > > Diff: https://reviews.apache.org/r/3272/diff > > > Testing > ------- > > I've tested with both -Dhadopoversion=20 and -Dhadoopversion=23. > > > Thanks, > > Jarek > >
