[ 
https://issues.apache.org/jira/browse/SQOOP-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174320#comment-13174320
 ] 

[email protected] commented on SQOOP-415:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3266/
-----------------------------------------------------------

(Updated 2011-12-21 19:03:52.238073)


Review request for Sqoop.


Changes
-------

Removed the original patch I had submitted, and replaced it with a new one. 
This one checks for double-quotes around oracle table names and owner names, 
and uppercases them if they aren't quoted.


Summary (updated)
-------

Uppercase table name and table owner name if it's not surrounded by double 
quotes.


This addresses bug SQOOP-415.
    https://issues.apache.org/jira/browse/SQOOP-415


Diffs (updated)
-----

  /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1221519 
  /src/java/org/apache/sqoop/manager/OracleManager.java 1221519 

Diff: https://reviews.apache.org/r/3266/diff


Testing (updated)
-------

This patch includes a unit test. Before the patch, sqoop fails for me when 
connecting to oracle. When built with this patch, it works. "ant test" passes.


Thanks,

Eric


                
> Oracle table names and table owner names should be uppercased in the code
> -------------------------------------------------------------------------
>
>                 Key: SQOOP-415
>                 URL: https://issues.apache.org/jira/browse/SQOOP-415
>             Project: Sqoop
>          Issue Type: Bug
>          Components: connectors/oracle
>    Affects Versions: 1.4.0-incubating
>            Reporter: Eric Wadsworth
>             Fix For: 1.4.1-incubating
>
>         Attachments: oracle_casing.patch
>
>
> Using sqoop with oracle fails for me, with this error:
> ERROR tool.ImportTool: Imported Failed: Attempted to generate class with no 
> columns!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to