----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3316/#review4132 -----------------------------------------------------------
Ship it! Hi Arvind, changes looks good, thank you very much for finding and fixing that bug! I've noticed that you've already attached the patch to corresponding JIRA, so I'll commit it shortly. Jarcec - Jarek On 2011-12-28 05:13:32, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3316/ > ----------------------------------------------------------- > > (Updated 2011-12-28 05:13:32) > > > Review request for Sqoop and Jarek Cecho. > > > Summary > ------- > > Added clean-up logic to the DBRecordReader so that in case of failure the > appropriate statement/connection is closed gracefully. > > Also added a couple of build properties which are needed to suppress Kerberos > warnings when running on Mac OS. For more information see > https://issues.apache.org/jira/browse/HADOOP-7489 > > > This addresses bug SQOOP-418. > https://issues.apache.org/jira/browse/SQOOP-418 > > > Diffs > ----- > > /build.xml 1222526 > /src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1222526 > > Diff: https://reviews.apache.org/r/3316/diff > > > Testing > ------- > > Ran all unit and third party tests. > > > Thanks, > > Arvind > >
