----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3412/#review4338 -----------------------------------------------------------
Look good overall. Just one nit below. http://svn.apache.org/repos/asf/incubator/sqoop/trunk/build.xml <https://reviews.apache.org/r/3412/#comment9768> "Can only be 20, 23, or 100." - Bilung On 2012-01-12 21:59:44, Karthik K wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3412/ > ----------------------------------------------------------- > > (Updated 2012-01-12 21:59:44) > > > Review request for Sqoop. > > > Summary > ------- > > Have a patch to build with hadoop 1.0.0 release as well. > > To specify the right hadoop version, override the following properties file. > > $HOME/build.properties: > ------------------ > hadoopversion=100 > > > This will build a sqoop client that can talk to hdfs/m-r 1.0.0 . > > > This addresses bug SQOOP-420. > https://issues.apache.org/jira/browse/SQOOP-420 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/incubator/sqoop/trunk/build.xml 1230798 > http://svn.apache.org/repos/asf/incubator/sqoop/trunk/ivy.xml 1230798 > > Diff: https://reviews.apache.org/r/3412/diff > > > Testing > ------- > > Yes. Tested with a sample hadoop 1.0.0 cluster with 3 nodes. > > > Thanks, > > Karthik > >
