----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3506/#review4407 -----------------------------------------------------------
Look good overall. Two nits below. /src/java/org/apache/sqoop/tool/ImportTool.java <https://reviews.apache.org/r/3506/#comment9922> Add a space after "if". /src/java/org/apache/sqoop/tool/ImportTool.java <https://reviews.apache.org/r/3506/#comment9921> "+" should be on a new line (from checkstyle). - Bilung On 2012-01-14 15:09:02, Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3506/ > ----------------------------------------------------------- > > (Updated 2012-01-14 15:09:02) > > > Review request for Sqoop, Arvind Prabhakar, Alex Newman, and Bilung Lee. > > > Summary > ------- > > I've tweaked parameter handling to rise an exception in case that both > --direct and --hive-drop-import-delims are present on the command line. > > > This addresses bug SQOOP-409. > https://issues.apache.org/jira/browse/SQOOP-409 > > > Diffs > ----- > > /src/java/org/apache/sqoop/tool/ImportTool.java 1231506 > > Diff: https://reviews.apache.org/r/3506/diff > > > Testing > ------- > > > Thanks, > > Jarek > >
