[
https://issues.apache.org/jira/browse/SQOOP-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224927#comment-13224927
]
jirapos...@reviews.apache.org commented on SQOOP-451:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4235/
-----------------------------------------------------------
(Updated 2012-03-08 01:52:58.860527)
Review request for Sqoop, Arvind Prabhakar and Bilung Lee.
Changes
-------
Move fixupColumnTypes() from ClassWriter to OracleManager (i.e. no longer
changing ClassWriter). It seems to fit better in OracleManager since that is
Oracle-specific.
Summary
-------
Oracle compatibility tests are fragile since the output format of timestamp
from the DB varies depending on versions. To test different versions
effectively, we should make the output more deterministic.
This patch is not going to be submitted unless a new option is added to Sqoop
so that new behaviors happen only if that option is enabled. I am posting my
patch only to collect feedback.
This addresses bug SQOOP-451.
https://issues.apache.org/jira/browse/SQOOP-451
Diffs (updated)
-----
./src/java/com/cloudera/sqoop/mapreduce/db/DBConfiguration.java 1297783
./src/java/com/cloudera/sqoop/mapreduce/db/DBRecordReader.java 1297783
./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
1297783
./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1297783
./src/java/com/cloudera/sqoop/mapreduce/db/OracleDBRecordReader.java 1297783
./src/java/com/cloudera/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1297783
./src/java/org/apache/sqoop/manager/OracleManager.java 1297783
./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1297783
./src/java/org/apache/sqoop/mapreduce/MySQLDumpImportJob.java 1297783
./src/java/org/apache/sqoop/mapreduce/MySQLExportJob.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBRecordReader.java
1297783
./src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java 1297783
./src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java
1297783
./src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBRecordReader.java
1297783
./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1297783
./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1297783
./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java
1297783
Diff: https://reviews.apache.org/r/4235/diff
Testing
-------
ant test
ant test -Dthirdparty=true
Note that all the Oracle-specific methods in OracleCompatTest are removed since
the same methods in ManagerCompatTest can be used as any other DBs.
Thanks,
Cheolsoo
> Add format string to select query for Oracle DB
> -----------------------------------------------
>
> Key: SQOOP-451
> URL: https://issues.apache.org/jira/browse/SQOOP-451
> Project: Sqoop
> Issue Type: Improvement
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Priority: Minor
>
> Oracle compatibility tests are fragile since the output format of timestamp
> from the DB varies depending on versions. To test different versions
> effectively, we should make the output more deterministic.
> This issue was originally raised by SQOOP-449, and using regular expressions
> in compatibility tests was suggested. But after discussion with Arvind and
> Bilung, we decided to add a format string for the date type to the select
> query for the Oracle DB so that the output format can be consistent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
