georgec wrote:
> The LMS player logs showed that the faad "binary" was being executed
> from
> "/Library/PreferencePanes/Squeezebox.prefPane/Contents/server/Bin/darwin",
> which I think makes it part of the distribution. (Plus, that's the file
> I replaced with my modified version.)
>
> Here's a listing of all the Darwin helper "binaries" from today's
> nightly build (March 29 2017 07:50) for OS X:
>
> -rwxrwxr-x 1 root admin 539300 Mar 24 02:07 wvunpack
> -rwxrwxr-x 1 root admin 5760644 Mar 24 02:07 sox
> -rwxrwxr-x 1 root admin 259924 Mar 24 02:07 sls
> -rwxrwxr-x 1 root admin 418 Mar 24 02:07 restart-server.sh
> -rwxrwxr-x 1 root admin 191 Mar 24 02:07 openprefs.scpt
> -rwxrwxr-x 1 root admin 306080 Mar 24 02:07 mac
> -rwxrwxr-x 1 root admin 8422 Mar 24 02:07 itartwork.scpt
> -rwxrwxr-x 1 root admin 1087116 Mar 24 02:07 flac
> -rwxrwxr-x 1 root admin 940364 Mar 24 02:07 faad
> -rwxrwxr-x 1 root admin 600 Mar 24 02:07 check-update.pl
>
> I'm not sure why the file update times all indicate Mar 24 - perhaps
> they are rebuilt from source on a weekly, not nightly, basis?
>
> Anyway, part of the difficulty with changing the faad source is that the
> LMS distribution applies a "Squeezebox Server" patch ("sbs.patch") to
> the source - "buildme-osx.sh" includes the following line:
>
> patch -p1 < ../sbs.patch >> $LOG
>
> So I'm guessing that any fix would involve an update to the "sbs.patch"
> file.
>
> I did try looking at the sox source code as well, and I didn't see any
> obvious shortcuts in argc/argv handling that I saw in faad. However,
> sox is so much more complex than faad that I'm a bit out of my depth
> when it comes to figuring out what the code is doing. In my LMS setup,
> I use faad almost all the time and sox almost never (maybe only when
> downsampling 192 kHz files?), so I was pretty certain faad was the cause
> of my problems even before looking at the source.
While you are discussing changes to the faad source, note that we
discovered another bug with faad during the community effort to get
bbciplayer working again in early 2015 (only windows was affected). The
actual source code modification required is detailed in this post:
http://forums.slimdevices.com/showthread.php?53229-Announce-BBCiPlayer-Plugin-(UK-only)&p=813434&viewfull=1#post813434.
At the time, Michael Herger was reluctant to make any changes to the
'official' version, since it had been stable for a very long time. So we
just distributed a new windows .exe to those that were bothered, given
in the first post in PasTim's quickfix guide:
'BBCiPlayer-Plugins-an-alternative-quick-fix-guide'
(http://forums.slimdevices.com/showthread.php?103435-BBCiPlayer-Plugins-an-alternative-quick-fix-guide&highlight=bbciplayer).
It would be nice to include this fix if the faad source is to be
updated.
------------------------------------------------------------------------
utgg's Profile: http://forums.slimdevices.com/member.php?userid=40900
View this thread: http://forums.slimdevices.com/showthread.php?t=107090
_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter
