slim/player/squeezebox2.pm


Code:
--------------------
    # Only send a setd packet to the player if it is stopped and we are not
  # still waiting for a response to a previous setd packet for this pref
  if ( $client->controller() && $client->isStopped() && !($status & 
SETD_WAITING) ) {
  
  my $data = pack('C'.$currpref->{pack}, $currpref->{firmwareid}, $value);
  $client->sendFrame('setd', \$data);
  
  # We are now waiting for a response to this setd call
  $client->pendingPrefChanges()->{$pref} = SETD_WAITING;
  }
  else {
  
  # we can't update the pref's while playing, cache this change for later
  $isInfo && $prefslog->info("Pending change for $pref");
  
  # Mark this pref as pending, will be sent to the player later
  $client->pendingPrefChanges()->{$pref} |= SETD_PENDING;
  }
  }
  
--------------------


I think that an issue with changing it will be verifying the change
across the range of devices and situations ... so perhaps if removing
the check on being stopped then add other checks that limit which
hardware/software players that it will be sent to to include only those
that are readily testable.
Michael probably best advisor on the though.



Paul Webster
http://dabdig.blogspot.com
Author Radio France (FIP etc) plugin
------------------------------------------------------------------------
Paul Webster's Profile: http://forums.slimdevices.com/member.php?userid=105
View this thread: http://forums.slimdevices.com/showthread.php?t=110157

_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter

Reply via email to