mherger wrote:
> > That seems to work. However as it is a LMS change (rather than
> > InternetRadio plugin) it could affect all plugins which use same
> > "Slim::Menu::TrackInfo->registerInfoProvider" - I'll do some checks
> on
> > other plugins just in case.
>
> OTOH it would also solve some of the other issues. Eg. the standard
> track info menu would provide some information about the item, which
> might be missing in the case of TuneIn, as the data would be stored with
>
> the main track, not the streaming track. The handler in the plugin could
>
> certainly extended to provide that information, too.
I think in general the change is right. There may be history - possibly
a change in playlist handling a few versions back and this bit of code
didn't get updated.
I did a visual code check of many of the LMS standard plugins and then
tested the ones that looked they might have an issue.
I think Plugins have coded for the playlist and the few which "noticed"
the issue have already taken measures.
The Material UI seems to behave like Squeezeplay and so "Tune-in Option"
appear even before the code change. So I just did checking with default
UI.
With code change when playing some items the "Tune-in Options" menu item
was shown but there are no submenu items in the menu.
I need to do more checking but there are issues with Favorites that
needs to be explored.
If you have a Tune-in saved as a Favorite and when playing after
clicking on "M" - the items "Tune-in Options" and "remove from
Favorites" are shown. Previously it would just be "save as Favorite"
However when clicking "Tune-in Options" - a message "saving as Favorite"
appears and no menu etc.
I also got an error message during one run - this could be a timing
issue like original problem.
Code:
--------------------
[19-07-04 12:34:20.0030] Slim::Networking::IO::Select::__ANON__ (131) Error:
Select task failed calling Slim::Web::HTTP::processHTTP: Can't call method
"url" on an undefined value at
/mnt/hddrive/home/ubuntu14.04//7.9/latest/trunk/Slim/Web/Pages/Trackinfo.pm
line 33.
--------------------
------------------------------------------------------------------------
bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806
View this thread: http://forums.slimdevices.com/showthread.php?t=110714
_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter
