mrw wrote: > Goodness me ! Did I get it right ? > > *Edit:* I should have asked: Did google give me the right answers ? A hat trick in fact.
Tested patch 3 on Windows - it fails on any number with commas which is expected. I'm not sure why but the patch didn't apply itself properly so I think I may be used wrong source for 1.3.2 from xiph.org. I think fixing flac locale to "C" is OK since LMS will only ever use "." in fractions in "skip" and "until" regardless of locale setting. I think "C" locale is in use on PCP, so the "C" locale has been reasonably tested in terms of formats and plugins. My gut feel is to create the simplest patch that does the job - which means exclusively working with LMS and is easy to align with future version of flac. I think this bug has been well and truly squashed. I think because flac source is not part of LMS git, a pull request cannot be done - so probably put patch in a comment on github Logitech/slimserver-vendor/flac ------------------------------------------------------------------------ bpa's Profile: http://forums.slimdevices.com/member.php?userid=1806 View this thread: http://forums.slimdevices.com/showthread.php?t=110871 _______________________________________________ Squeezecenter mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/squeezecenter
