Ok I am pretty sure I found the issue. Debugging both the Networking and
Player components of LMS was the key.

As seen in the attached log, the Networking requests return 200 OK,
while the Player requests return 403 Forbidden. The reason is the way
Player builds it's requests, which is slightly different than
Networking. 'Player adds a port to the Host header if it is anything
other than port 80'
(https://github.com/Logitech/slimserver/blob/public/8.1/Slim/Player/Protocols/HTTP.pm#L702).
But 'Neworking only adds a port to the Host header if it is not default
to the specific protocol (http, https)'
(https://github.com/Logitech/slimserver/blob/public/8.1/Slim/Networking/Async/HTTP.pm#L250).
And this behavior can be seen in the log: no port on the Host header in
Networking requests; port 443 added to the Host header on the Player
requests. (Networking also adds additional Cookie headers, but that is
beyond the current issue).

Now, the reason this returns 403 Forbidden may only be specific to my
case. However, I think it would be best practice for LMS to create
requests as similar as possible between these two components. Therefore
I think 'Player'
(https://github.com/Logitech/slimserver/blob/public/8.1/Slim/Player/Protocols/HTTP.pm)
should be modified to resemble 'Networking'
(https://github.com/Logitech/slimserver/blob/public/8.1/Slim/Networking/Async/HTTP.pm)
in the way the Host header is built. I may try to create a PR for this
issue. It probably would have been more appropriate to post this thread
on github, but thank you everyone for your help and suggestions.


+-------------------------------------------------------------------+
|Filename: server.log                                               |
|Download: http://forums.slimdevices.com/attachment.php?attachmentid=32958|
+-------------------------------------------------------------------+

------------------------------------------------------------------------
daveaudi0's Profile: http://forums.slimdevices.com/member.php?userid=71231
View this thread: http://forums.slimdevices.com/showthread.php?t=113665

_______________________________________________
Squeezecenter mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/squeezecenter

Reply via email to