Hi, +0 from me: the only thing I don't understand is the XXX in parsedSize(); it's not clear why the comment, and what to use instead. as soon as that's improved, +1.
On Thu, Jul 23, 2015 at 12:41 AM, Alex Rousskov < [email protected]> wrote: > Hello, > > The attached patch adds SBuf and Tokenizer methods to simplify > suffix parsing and skipping (and to make suffix/reverse APIs more > similar to prefix/forward ones). The new methods are used in another > patch (to be posted shortly) that makes the request line parser simpler > and more robust, but they are useful in other contexts as well IMO. > > For consistency sake, I tried to mimic the existing Tokenizer/SBuf > documentation, debugging, and code duplication styles. > > > One old problem was detected and documented during this project: The > Tokenizer::parsedSize() method does not account for the successfully > parsed and removed suffix/trailing characters in most cases. That method > should be revised or removed. Solving this problem is outside this > project scope. > > > This and the following patch are based on trunk r14083. I will update to > the current trunk if the patches are approved. Please let me know if you > want to review the updated versions as well. > > > HTH, > > Alex. > > _______________________________________________ > squid-dev mailing list > [email protected] > http://lists.squid-cache.org/listinfo/squid-dev > > -- Francesco
_______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
