On 29/10/2015 2:05 a.m., Kinkie wrote: > Hi all, > this is the final patch of my current drive on mempools-nozero (aka > convert explicit pool users to MEMPROXY_CLASS). > Build-and run-tested, big-context diff. > > Thanks >
Thank you. in src/DiskIO/DiskThreads/DiskThreads.h: * do you have enough knowledge about the new classes now to write a doxygen description for them? * please use doxygen syntax for the new label comments in src/DiskIO/DiskThreads/DiskThreadsIOStrategy.cc: * please use C++ casting on new and altered lines with casts. - DiskThreadsIOStrategy::callback at least has one. in src/DiskIO/DiskThreads/aiops.cc: * since you are changing the pool lines documentation, please make them all use doxygen comments and nullptr. Otherwise this looks fine. +1. Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
