On 10/12/2015 10:19 a.m., Amos Jeffries wrote: > On 10/12/2015 7:42 a.m., Alex Rousskov wrote: >> Hello, >> >> The attached patch does four things: >> >> 1. Fixes shared memory initialization. The OS X portability fix (Bug >> 3805) is a gift that keeps on giving: After we fixed OS X compilation, >> we stopped initializing previously used shared memory after crashes! >> Search the patch for "truncate". >> >> 2. Fixes shared memory cleanup. One segment was not deleted when running >> Squid in non-daemon mode (-N). Search the patch for "UsingSmp". >> >> 3. Makes sure using shared memory does not lead to SIGBUS crashes. >> Search the patch for "mlock". >> >> 4. Adds tests to check whether shared memory is usable. Search the patch >> for "memory checks" and "shouldTest". >> >> >> My plan is: >> >> * Commit #1 and #2 fixes to trunk without review unless somebody >> requests one now: IMO, they are simple and non-controversial. >> > > +1 for #1 bits. ... without the new "HERE" macros.
I meant +1 for both #1 and #2. Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
