On 12/30/2015 10:05 AM, Kinkie wrote: > Sure. Are you +1'ing the patch (with the change)?
In general, I hesitate +1ing patches that I have not closely reviewed. I have not verified that QDTEXT initialization is correct, for example. Please note that your own [implied] +1 should be enough if you are confident that this is the right change. Besides the inlining issue, you have some inconsistent NULL/nullptr use [in test cases]. If the proposed commit message does not disclose addition of the previously commented-out sets, please amend it. I did not notice any other problems with the patch. Thank you, Alex. > On Wed, Dec 30, 2015 at 5:52 PM, Alex Rousskov > <[email protected]> wrote: >> On 12/30/2015 09:12 AM, Kinkie wrote: >> >>> +CharacterSet >>> +operator+ (CharacterSet lhs, const CharacterSet &rhs); >> >>> +CharacterSet >>> +operator- (CharacterSet lhs, const CharacterSet &rhs); >> >> I recommend inlining these two. >> >> Alex. >> > > > _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
