On 17/03/2016 5:25 p.m., Nathan Hoad wrote: > On 17 March 2016 at 13:33, Alex Rousskov > <[email protected]> wrote: >> On 03/16/2016 05:40 PM, Nathan Hoad wrote: >> >>> I've opted to remove Config2.onoff.mangle_request_headers completely. >> >> Even better! I did not realize it is not a "real" configuration option >> but a silly(?) cache for "Config.request_header_access != NULL". >> >> >>> -httpHdrMangle(HttpHeaderEntry * e, HttpRequest * request, int req_or_rep) >>> +httpHdrMangle(HttpHeaderEntry * e, HttpRequest * request, HeaderManglers >>> *hms, int req_or_rep) >> >> I do not think you need/use the last parameter, but its removal can be >> done when committing your patch. > > Good catch! To lessen work for the committer, I've attached a version > of the patch with that change. >
in src/HttpHeaderTools.cc: * you dont have to compare pointers with "!= nullptr" or "== nullptr". in src/enums.h: * since you are touching req_or_rep enum anyway please move it to HttpHeaderTools.h - then you can remove the #include for enums.h again in src/cf.data.pre: * use " [ acl ... ] " instead of "[acl1] ..." Thanks Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
