On 21/05/2016 8:11 a.m., Alex Rousskov wrote: > On 04/11/2016 09:16 AM, Alex Rousskov wrote: >> On 04/09/2016 10:50 PM, Amos Jeffries wrote: >> >>> In principle this is a great step forward, but I would like confirmation >>> about the portability side of things before it actually gets merged. > > >> Me too. [...] >> >> FWIW, the patch did compile fine on a few Linux boxes and one MacOS laptop. > > * the existing code causes problems and violates C++ rules > * the fix does not have known problems > * the fix has been tested on several platforms > * nobody has committed to report results for untested platforms > * the Squid Project provides no access to those untested platforms > * testing this code is difficult so the set of volunteers is tiny > > Given the above, I suggest to apply polished changes to trunk and see > what happens on those untested and hard-to-get-to platforms. Any > objections or better ideas? >
None from me. +1 and please apply. Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
