Hi Amos, I fixed the free_path following your suggestion.
I run also indent -br -ce -i4 -ci4 -l80 -nlp -npcs -npsl -d0 -sc -di0 -psl over it as it is C based code. Is that the correct or is there another tool to format the code. Not sure which debug message lines you meant.
Thank you Markus-----Original Message----- From: Amos Jeffries
Sent: Thursday, July 14, 2016 12:58 PM To: Markus Moeller ; [email protected] Subject: Re: [squid-dev] [PATCH] Fix ssl use for kerberos_ldap_group On 3/07/2016 4:57 a.m., Markus Moeller wrote:
Hi Amos, Here is a small patch for cases SSL must be used to connect to an ldap server.
Looks okay, except for two minor things.
* some debug messages are missing a space between end of one sentence
and the '(' starting the next. Search for ".("
* what about xstrdup()'ing the output of getenv() so you can drop the
free_path variable and if-statements wrapping xfree() ?
Cheers
Amos
squid-trunk-klg-2.patch
Description: Binary data
_______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
