On 11/08/2016 11:50 p.m., Eduard Bagdasaryan wrote: > 2016-08-10 19:03 GMT+03:00 Alex Rousskov > <rouss...@measurement-factory.com>: > >> As Amos has noted, we do need to restore the old "unknown" behavior when >> the helper is _missing_ (and not overloaded), but that is a completely >> different problem with a simple solution: SubmissionFailure() should use >> Helper::Unknown when its hlp parameter is nil and Helper::Error. > > Adjusted accordingly and updated the patch. >
Since we seems to have consensus that the 'err' value means ERR, and other codes will be added later. The config value should likewise be the result code, uppercase "ERR", and the wording "responded with an error" be "responded with ERR". That makes it crystal clear that whatever the helper ERR handling is will happen. If there are no further objections, I will apply it tomorrow (~12hrs) with the above change. Amos _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev
