On 14/09/2016 2:52 a.m., Alex Rousskov wrote: > On 09/12/2016 10:06 PM, Amos Jeffries wrote: >> Just the new cf.data.pre docs for icap_log contradicting itself: >> >> " >> http::>h ... >> HTTP response headers in RESPMOD) ... >> currently does not support logging of HTTP response headers in >> RESPMOD ... >> " >> >> I think that should probably be saying it does not support HTTP >> *request* headers in RESPMOD. > > I assume you are talking about this blob:
Yes. > >> http::>h >> To-be-adapted HTTP message headers sent by Squid to >> the ICAP service (HTTP request headers in REQMOD; HTTP >> response headers in RESPMOD). Please note that Squid >> currently does not support logging of HTTP response >> headers in RESPMOD for this format code. > > I will clarify that when committing: > > http::>h To-be-adapted HTTP message headers sent by Squid to the ICAP > service (i.e., HTTP request headers in REQMOD or HTTP response headers > in RESPMOD). However, Squid cannot currently log HTTP response headers > sent to the ICAP service (i.e., %http::>h will expand to "-" for RESPMOD > transactions). > > Does that sound better? > Better, but I think remove the words "or HTTP response headers in RESPMOD" from that first statement. The second sentence now explains the RESPMOD clearly all by itself. Amos _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev
