On 7/10/2016 6:20 a.m., Alex Rousskov wrote: > On 10/06/2016 10:57 AM, Amos Jeffries wrote: > >> Please add a check to the unit test testSBuf::testAppendSBuf() >> to guarantee that the (*this = S) assignment code path updates the store >> reference count rather than doing a bit-wise copy of the SBuf. > > I support that addition but do not have the time to implement it right > now. It would also be nice to add a test case that the optimized > assignment path does _not_ happen for pre-allocated SBufs. >
Test case added as trunk rev.14911 SBuf::append patch applied as trunk rev.14912 Amos _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
