On 11/13/2016 11:02 PM, Amos Jeffries wrote: > On 14/11/2016 6:36 p.m., Alex Rousskov wrote: >> On 11/13/2016 10:15 PM, Amos Jeffries wrote: >> >>> I think we should accumulate into two SBufList instead, one for -i and >>> one for +i instead of switching back and forth with potentially lots of >>> little patterns. >> >> Would not forcing regexes into two different groups change the regex >> evaluation order and, hence, make it more difficult for some admins to >> optimize their regexes by placing frequently matching regexes earlier? >> >> I am still not quite sure what problem we are trying to solve exactly >> here, but allowing admins to control exact regex evaluation order seems >> important [for some admins]. > > Good point. > > AFAIK the goal is twofold; > > 1) removing wordlist usage. > > It gets replaced with SBufList. > > 2) improved performance. > > One of the often raised reasons for people still using re-writer > helpers is that Squid regex take so long to reconfigure when big (MB) > lists are used.
For the record, I do not plan on reviewing this patch further. I did what I could, but there is just too much information missing for me to reconstruct the exact intent and evaluate the results. IMHO, I should not be parsing large raw dumps to figure out what the patch does or does not do. I am sure you and Kinkie do not need me to finish this. Thank you, Alex. _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
