On 2017-01-06 04:32, Alex Rousskov wrote:
On 01/04/2017 07:42 PM, Amos Jeffries wrote:
This patch removes String.cci file, moving the simple methods inline to
the SquidString.h and more complicated others to String.cc.

Thank you for doing this long-overdue cleanup.


+    /// throws when size() > INT_MAX
+    int psize() const {
+        Must(size() < INT_MAX);
+        return size();

The code does not match its description: The code also throws when
size() is exactly INT_MAX for some reason.

Please commit when you are comfortable with the code.

Alex.

Thanks for that catch.

Applied to v5 as rev.14996.

Amos

_______________________________________________
squid-dev mailing list
[email protected]
http://lists.squid-cache.org/listinfo/squid-dev

Reply via email to