On 01/07/2017 07:33 PM, Amos Jeffries wrote: > This now just depends on the client_side_request_cci_remove_mk1.patch > submitted earlier. > > With the .cci files gone there is no longer any use of the SQUID_INLINE > macro. Which in turn removes the need for _USE_INLINE_ macro and then > the --disable-inline build option which sets that.
Perhaps I am missing some other yet-uncomitted changes, but bzr shows me some 30 _SQUID_INLINE_ macros in r15000 and client_side_request_cci_remove_mk1.patch does not remove all of them. See bzr grep _SQUID_INLINE_. Please remove all _SQUID_INLINE_ before or while removing --disable-inline. No need to repost this patch for that reason alone IMO. > The relevant compiler specific *FLAGS option should be used instead to > disable compiler inlining functions without special macro usage. Yes, of course. And we have --disable-optimizations that should be used in 99% of relevant cases anyway. Thank you, Alex. _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev