On 03/16/2017 01:43 AM, Amos Jeffries wrote: > On 6/03/2017 3:54 p.m., Alex Rousskov wrote: >> On 03/05/2017 12:28 PM, Eduard Bagdasaryan wrote: >>> ufsdump build is broken now [...] >>> This patch fixes this, however I am not sure that >>> does it in a best possible way. For example, someone may argue that >>> inlining storeKeyText() is wrong.
>> Yeah, I would argue that such inlining is "wrong". > Any particular reason(s) beyond the static local variable? * explicit inlining of a non-trivial function that should not be used on a performance sensitive path * exposing a "heavy" external interface: snprintf() * exposing an external interface: SQUID_MD5_DIGEST_LENGTH * local static Alex. _______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev
