Hi everyone,

while I was testing the use of the rock store on a ZFS pool using file system block sizes of 4K, 8K and 16K, I noticed that cachemgr.cgi always printed "FS Block Size = 1024" in all cases.

I tracked down the issue by comparing Rock::SwapDir::init() to Fs::Ufs::UFSSwapDir::init(). I discovered a missing instruction. Following is the proposed patch that applies to Squid 3.5.26.

Regards,

Stéphane Ouellette
--- squid-3.5.26/src/fs/rock/RockSwapDir.cc	2017-06-08 22:29:00.179200500 -0400
+++ squid-3.5.26-fixed/src/fs/rock/RockSwapDir.cc	2017-06-08 22:25:57.590936314 -0400
@@ -342,6 +342,8 @@
     // others start, storeRebuildComplete() will think the rebuild is over!
     // TODO: move store_dirs_rebuilding hack to store modules that need it.
     ++StoreController::store_dirs_rebuilding;
+
+    (void) storeDirGetBlkSize(path, &fs.blksize);
 }
 
 bool
_______________________________________________
squid-dev mailing list
[email protected]
http://lists.squid-cache.org/listinfo/squid-dev

Reply via email to