On 07/16/2017 06:40 AM, Amos Jeffries wrote: >> On 16/07/17 16:43, Alex Rousskov wrote: >>> I tried to "lock" the >>> official repository on Github to prevent commits (without pull >>> requests), but I have not tested whether that lock was successful.
> Assuming the way you locked it was to require PR review, it seems to > be working: Well, the PR requirement was intentional while the review requirement was a surprise side effect. I actually like that side effect! Since we will switch to PR-only commit path (for master) as soon as Eduard's CI integration is ready, I suggest that we keep the current review-required setup to practice. We can always undo/relax it if we discover problems, and it is better to discover as much of them as possible _now_, in a simplified environment without CI. Do you think testing the PR review requirement before CI is ready is a good idea? Thank you, Alex. _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
