On 08/27/2017 08:50 PM, Amos Jeffries wrote: > I have a patch in my TLS config branch, if it looks okay with you I will > make a PR to add it separately. > https://github.com/yadij/squid/commit/192c5b931a5b0484246e21fd02310974131d32a6
> + AC_DEFINE_UNQUOTED(const_ASN1_BIT_STRING, [ASN1_BIT_STRING]) > + AC_DEFINE_UNQUOTED(const_X509_ALGOR, [X509_ALGOR]) I do not think we should lie about the actual constness of those types. I suggest using something like extracted_ASN1_BIT_STRING and extracted_X509_ALGOR names instead. > - X509_ALGOR *sig_alg; > + const_X509_ALGOR *sig_alg; Please use this opportunity to initialize sig_alg to nullptr before passing it to an external function. The other parameter (sig) is already initialized. > There also seems to be a regression in the last branch merge with the > 'bio' variable. > > ../../../../src/ssl/support.cc:1481:10: error: ‘bio’ was not declared in this > scope > ../../../../src/ssl/support.cc:1483:18: error: ‘bio’ was not declared in this > scope I see the bug and will submit a fix candidate. Evidently, the older CI tests did not have HAVE_LIBCRYPTO_BIO_METH_NEW defined. Hopefully, the matrix tests will do better. Thank you, Alex. _______________________________________________ squid-dev mailing list [email protected] http://lists.squid-cache.org/listinfo/squid-dev
