Following up. TL;DR: it's pointless. Spaces in paths are not safe and do not work. Even if we were to make our own scripts safe - which the feature tree above does - configure will barf if there are spaces in the source tree path, and libtool will fail assembling a safe compile command if there are spaces in the build path.
The feature branch is at https://github.com/kinkie/squid/tree/securify-test-builds This was tested on MacOS Catalina with - autoconf 2.69 - libtool 2.4.6 - gmake 3.81 - clang 11 On Tue, Feb 18, 2020 at 8:40 AM Francesco Chemolli <gkin...@gmail.com> wrote: > Hi all, > as a followup to discussion on PR 555, I was looking into safely > handling source code paths with spaces. > > Turns out worrying is pointless: after doing the needed changes, doing a > test build with > builddir = "/Users/kinkie/src/test build with space" > srcdir = "/Users/kinkie/src/squid dir with space" > on MacOS catalina with homebrew > > resulted in configure failing with error: > checking whether build environment is sane... configure: error: unsafe > srcdir value: '/Users/kinkie/src/squid dir with space/test-suite/..' > > If there is no regression with my changes, I'll submit the PR anyway, but > its benefits will be limited. > > -- > Francesco > -- Francesco
_______________________________________________ squid-dev mailing list squid-dev@lists.squid-cache.org http://lists.squid-cache.org/listinfo/squid-dev