Adrian: What was the exact number of filedescriptors you configured Squid for using?
I am a bit reluctant about doing this change in Squid-2.5 as to me this large (but non-intrusive) change does not seem to be needed if the FD_SETSIZE override is fixed to ensure the new size gets rounded up properly. Note: Your patch relies on the undocumented "howmany" macro which just happens to be found in the glibc headers with a suitable definition.. I do not mind if the fd_set dependency is killed in delay pools and comm code for Squid-3 (obviously save for select() processing). In fact I would encourage this happening there. Regards Henrik On Thursday 27 February 2003 11.59, Adrian Chadd wrote: > Hiya, > > I'd like to remove the fd_set stuff from delay pools. > My first hack was to turn the fd_set's into arrays. > That looked fine. :-) > > Do people have an issue with this? The downside is the > byte-per-fd wasted but considering how much RAM squid normally > uses I don't see it as an issue. > > What do people think? > > > > > Adrian
