HttpRequest has references to two HttpHdrRange instances, instead of just one.

1. HttpRequest.header.getRange() <-- returns the relevant entry in the 'entries' vector
   2. HttpRequest.range <-- is a R/W cached copy of the above header

The second instance is set at various times by HttpRequest::hdrCacheInit() (which kindly reminds you to "sync this routine when you update HttpRequest struct"), clientInterpretRequestHeaders() and HttpStateData::httpBuildRequestHeader()

Having two copies of this header, especially a cached copy which is read-write and frequently written to, seems like an open invitation to errors. Is there a good reason for this or can I refactor into something better?

Cheers
Doug


Reply via email to