for (;;) {
        num = epoll_wait(kdpfd, pevents, SQUID_MAXFD, msec);
        statCounter.select_loops++;

        if (num >= 0)
            break;

        if (ignoreErrno(errno))
            break;

        getCurrentTime();

        PROF_stop(comm_check_incoming);

        return COMM_ERROR;
    }

Isn't this equivalent to 
{
   num = epoll_wait(kdpfd, pevents, SQUID_MAXFD, msec);
   statCounter.select_loops++;
   if (num < 0 && !ignoreErrno(errno)) {
       getCurrentTime();
       PROF_stop(comm_check_incoming);
       return COMM_ERROR;
}

That is - isn't the for loop completely irrelevant ?

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to