On Sat, 2006-09-09 at 10:17 +0200, kinkie wrote: > > http://www.squid-cache.org/bugs/show_bug.cgi?id=1763 has attached to it > > a split out of the client protocol support from protocol_t. > > > > This is fairly important to folk wanting to write new client protocol > > modules - at the moment they need to perform shotgun surgery all through > > the code base because the protocol gets listed as a protocol_t, which > > also appears in the logic for request forwarding etc etc etc. > > > > The patch is good enough to commit at the moment IMO. > > Hi, > I haven't tested it, but skimming over its contents I had some thoughts > popping out: > > Is the allocator stuff intentionally in? (cosmetic issue)
Its required - the per-protocol ClientProtocolStats need to be allocated via mempools as they have 1000's of instances on busy caches and will fragment if not slab allocated. > Is it complete? (logTypeIsAHit seems only halfway refactored) No, thats complete, a log type is a hit if its a UDP hit, or any of the tcp hits. > Aren't we losing information by moving the allocator of ClientInfo from > memAllocate to xmalloc? Huh ? Its still MemPool allocated. Cheers, Rob -- GPG key available at: <http://www.robertcollins.net/keys.txt>.
signature.asc
Description: This is a digitally signed message part
