On Thu, 2007-05-24 at 11:19 +0200, Henrik Nordstrom wrote: > Should we back out SqString for now until the implicit cast issues have > been analyzed in more detail, or try fixing it somehow for the 3.0 > release? > > http://www.squid-cache.org/bugs/show_bug.cgi?id=1970 > > My vote is to defer the SqString change to 3.1, or at least after 3.0 > has been branched from HEAD. > > Reasoning: More work is required to polish it, and it doesn't really add > anything to the 3.0 release (beyond the bugfixes it triggered > indirectly), mainly preparation for future work.
I still think SqString "API" changes should not be in 3.0, but I do not have a strong opinion and do not want to be the one backing them out. We could adopt a middle-ground solution. The changes limited to renaming String methods to match std::string API can stay. The changes introducing new operators, conversions, or methods should be postponed until v3.1. Same for changes in the code that uses Strings: renaming is fine, rearranging and optimizing things is not. HTH, Alex.