Amos,
Do you remember why you had to remove const here? Does
comm_connect_addr modify its IPAddress parameter from the caller point
of view?
Thank you,
Alex.
On Sat, 2008-03-22 at 06:00 +0000, Amos Jeffries wrote:
> Update of cvs.devel.squid-cache.org:/cvsroot/squid/squid3/src
>
> Modified Files:
> Tag: ayjwork
> comm.cc comm.h
> Log Message:
> Remove annoying const.
>
>
> Index: comm.h
> ===================================================================
> RCS file: /cvsroot/squid/squid3/src/comm.h,v
> retrieving revision 1.23.4.6
> retrieving revision 1.23.4.7
> diff -C2 -d -r1.23.4.6 -r1.23.4.7
> *** comm.h 4 Mar 2008 10:23:28 -0000 1.23.4.6
> --- comm.h 22 Mar 2008 06:00:07 -0000 1.23.4.7
> ***************
> *** 47,51 ****
> void commConnectStart(int fd, const char *, u_short, AsyncCall::Pointer
> &cb);
>
> ! SQUIDCEXTERN int comm_connect_addr(int sock, const IPAddress &addr);
> SQUIDCEXTERN void comm_init(void);
> SQUIDCEXTERN void comm_exit(void);
> --- 47,51 ----
> void commConnectStart(int fd, const char *, u_short, AsyncCall::Pointer
> &cb);
>
> ! SQUIDCEXTERN int comm_connect_addr(int sock, IPAddress &addr);
> SQUIDCEXTERN void comm_init(void);
> SQUIDCEXTERN void comm_exit(void);
>
> Index: comm.cc
> ===================================================================
> RCS file: /cvsroot/squid/squid3/src/comm.cc,v
> retrieving revision 1.72.4.11
> retrieving revision 1.72.4.12
> diff -C2 -d -r1.72.4.11 -r1.72.4.12
> *** comm.cc 4 Mar 2008 10:23:28 -0000 1.72.4.11
> --- comm.cc 22 Mar 2008 06:00:07 -0000 1.72.4.12
> ***************
> *** 1127,1131 ****
>
> int
> ! comm_connect_addr(int sock, const IPAddress &address)
> {
> comm_err_t status = COMM_OK;
> --- 1127,1131 ----
>
> int
> ! comm_connect_addr(int sock, IPAddress &address)
> {
> comm_err_t status = COMM_OK;
