Alex Rousskov wrote:
On Mon, 2008-04-14 at 12:23 +1200, Amos Jeffries wrote:
The .cc include sequence should be:
- config.h / squid.h
- class .h (for the .cc)
- other squid .h still needed by the .cc code internals
- other system headers still needed by the .cc internal code
Many squid source files do not follow this convention. If there is
consensus that all files should follow it, a script can probably reorder
#includes or at least check the order.
It's not a serious requirement. Just a convention I encountered years
ago that makes a lot of large-code easier to navigate and identify the
problem spots while writing. With a nice side-effect of minimizing the
number of includes.
I'm cleaning this up incrementally with the globals dependencies.
Amos
--
Please use Squid 2.6.STABLE19 or 3.0.STABLE4
