On Fri, 2008-08-22 at 17:50 +0200, Kinkie wrote: > On Fri, Aug 22, 2008 at 4:48 PM, Adrian Chadd <[EMAIL PROTECTED]> wrote: > > 2008/8/22 Kinkie <[EMAIL PROTECTED]>: > >> Hi all. > >> The wordlist-refactor branch is from my point of view feature-complete. > >> It can be found in Launchpad, at > >> https://code.launchpad.net/~kinkie/squid/wordlist-refactor. > >> I'm not posting a bundle to propose merging into trunk at this time, > >> because despite the patch being quite self-contained, some core > >> developers have expressed concerns about it potentially introducing > >> subtle bugs, and suggested it to be merged after branching 3.1. > > > > I like the general idea. It and wordlist need to be looked at. > > > > I hate that using it in the ACL code (one big user) involves a casting > > from a void * pointer, guess thats difficult to avoid in old C code. > > I'm trying to nibble here and there to make it less and less > necessary. It's a LOONG effort, but in the mid-term I'm convinced > it'll pay off: increased modularity and code clarity will facilitate > work on the 'real' performance-enhancing stuff.
Improving code quality is as real as performance-enhancing stuff. Thank you for doing this. Alex.
