On Thu, 2008-08-28 at 15:16 +1000, Benno Rice wrote: > RFC-compliant object invalidation behaviour. > > - Switch the default from not purging if the method is unknown to purging if > the method is unknown.
> - return false; // be conservative: we do not know some methods specs > + return true; // RFC says to purge if we don't know the method Perhaps add that the RFC says SHOULD purge and refer to Section 13.10? This requirement will probably surprise a few developers so it is better to be explicit. Also, if you change the default to return true, then we can delete all "return true" cases in the same HttpRequestMethod::purgesOthers() method. This will make the method a tiny bit faster. > - When purging URIs sourced from Location and Content-Location headers, make > sure the URL is absolute before a) comparing it to see if hosts match and b) > actually trying to find it in the store. > > These changes are based on changes made to squid 2. In particular, the > urlAbsolute function was ported from squid 2. I would appreciate it if people > paid particular attention to urlAbsolute to make sure I'm not doing anything > that would cause problems in squid 3. urlAbsolute() is not yet documented in the patch. Please add a few comments to explain what it does and why we cannot use some of the existing URL formatting routines [and then check their output] to arrive at the answer. Thank you, Alex.
