On Wed, 2008-09-03 at 14:44 +1000, Benno Rice wrote: > Address Alex and Amos' comments. > > - Use bool instead of int for urlIsRelative. > - Document what leads to a NULL return in urlMakeAbsolute and mention the > responsibility of the caller to free the result in the non-NULL case. > - Declare variables closer to where they're used. > - Fix indentation.
I have no more serious objections but cannot vote "approve" since I did not review the internals of urlMakeAbsolute. Is that a valid reason to bb:abstain? Thank you for your patience and especially the continued stream of improving patches. I am looking forward to seeing this committed. Alex.
