Hi Francesco,
I have some problems trying to compile the string-fix branch.
with --enable-icap-client I am getting:
ICAPOptions.cc: In member function ‘bool
ICAPOptions::TransferList::matches(const String&) const’:
ICAPOptions.cc:179: error: passing ‘const String’ as ‘this’ argument of
‘char& String::operator[](unsigned int)’ discards qualifiers
with --enable-x-accelerator-vary:
store.cc: In member function ‘void StoreEntry::setPublicKey()’:
store.cc:699: error: ‘class String’ has no member named ‘buf’
store.cc:701: error: ‘class String’ has no member named ‘buf’
with --enable-esi :
ESI.cc: In member function ‘virtual esiProcessResult_t
esiLiteral::process(int)’:
ESI.cc:1581: error: ‘class ESISegment’ has no member named ‘unsafeBuf’
ESI.cc: In function ‘int esiEnableProcessing(HttpReply*)’:
ESI.cc:2433: error: ‘class String’ has no member named ‘buf’
I am able to compile it (and use it) with the following options:
./configure --with-pthreads --enable-icmp --enable-linux-netfilter
--with-large-files --prefix=/usr/local/squid3-cvs/ --enable-snmp
--enable-delay-pools--enable-arp-acl --enable-ssl
--enable-storeio=ufs,aufs,diskd
--enable-disk-io=AIO,Blocking,DiskDaemon,DiskThreads
--enable-auth=basic,digest,negotiate,ntlm
--enable-basic-auth-helpers=NCSA,LDAP
--enable-digest-auth-helpers=ldap,password --with-filedescriptors=16384
Regards,
Christos
Kinkie wrote:
Hi all,
here's the first merge request for the string-fix branch.
It includes marking String::buf() to unsafeBuf(), introduces the
rawBuf(), termedBuf(), defined() and undefined() methods to String, and
begins the analysis effort on the callers (mostly in ICAP-related
parts).
I've build-, unit- and run-tested it.
Cheers,
Francesco
